Save signals on first workflow task #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffschoner
force-pushed
the
save-signals-for-first-task
branch
from
9b9af08 to
d3a2869
Compare
jeffschoner
force-pushed
the
save-signals-for-first-task
branch
from
206bd48 to
dcad0f9
Compare
DeRauk
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #267. See that issue for more details on the bug.
This change makes signals available to code running in the first workflow task by saving any signals received before the first workflow task, then calling any signal handler registered during the first workflow task with these saved values. Because this change would otherwise affect the determinism of all workflows that start workflows with a signal, it adds a new SDK flag to preserve the previous behavior for existing workflow histories.
This is achieved by registering a special signal handler that saves signals during the first workflow task. Any signal handlers registered during the first workflow task will be immediately called with any of these saved signals. After code passes the first workflow task, the handler is removed and behavior returns to normal.