Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate :use_error_serialization_v2 option to GRPC client #296

Merged
merged 1 commit into from
May 9, 2024
Merged

Propagate :use_error_serialization_v2 option to GRPC client #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/temporal/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def for_connection
port: port,
credentials: credentials,
identity: identity || default_identity,
connection_options: connection_options
connection_options: connection_options.merge(use_error_serialization_v2: @use_error_serialization_v2)
).freeze
end

Expand Down
2 changes: 1 addition & 1 deletion lib/temporal/connection/grpc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def respond_activity_task_completed_by_id(namespace:, activity_id:, workflow_id:
end

def respond_activity_task_failed(namespace:, task_token:, exception:)
serialize_whole_error = Temporal.configuration.use_error_serialization_v2
serialize_whole_error = options.fetch(:use_error_serialization_v2, Temporal.configuration.use_error_serialization_v2)
request = Temporalio::Api::WorkflowService::V1::RespondActivityTaskFailedRequest.new(
namespace: namespace,
identity: identity,
Expand Down