Add colcon-override-check as a recommended dependency #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of this change is that a typical installation of colcon from debs would result in installation of the colcon-override-check extension, but that specifically excluding or uninstalling that package won't result in colcon-common-extensions' dependencies being unmet.
gbiggs
approved these changes
Mar 15, 2022
nuclearsandwich
approved these changes
Mar 16, 2022
Comment on lines
+52
to
+54
| [options.extras_require] | ||
| recommended = | ||
| colcon-override-check |
There was a problem hiding this comment.
I think it's good either way but is extras_require[recommended] an accepted community norm or is this something that we're trailblazing based on distro packaging conventions?
There was a problem hiding this comment.
I've found no precedent. Fundamentally, the purpose of extras_require is to list optional or recommended dependencies that aren't strictly required, so we're not very far out by using it like this. That said, I found no uses of the name recommended, and this is also essentially a Python metapackage, for which there is little precedent to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this change is that a typical installation of colcon from debs would result in installation of the colcon-override-check extension, but that specifically excluding or uninstalling that package won't result in colcon-common-extensions' dependencies being unmet.