Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote package override error to a warning #466

Merged
merged 2 commits into from
Dec 23, 2021
Merged

Demote package override error to a warning #466

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e718d5a
Demote package override error to a warning
cottsay Dec 23, 2021
a165214
Update wording
cottsay Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion colcon_core/verb/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,10 @@ def main(self, *, context): # noqa: D102
' line:'
'\n\t--allow-overriding ' +
' '.join(sorted(override_messages.keys())))
raise RuntimeError(override_msg)

logger.warn(
override_msg + '\n\nThis will be promoted to an error in a'
' future release of colcon-core.')

on_error = OnError.interrupt \
if not context.args.continue_on_error else OnError.skip_downstream
Expand Down