Don't warn about overriding when building the a workspace that has al… #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2022
sloretz
force-pushed
the
sloretz__no_override_warn_when_same_prefix_sourced
branch
from
0545a4b to
4444925
Compare
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
- Coverage 80.81% 80.76% -0.05%
==========================================
Files 59 59
Lines 3518 3520 +2
Branches 668 669 +1
==========================================
Hits 2843 2843
- Misses 630 632 +2
Partials 45 45
Continue to review full report at Codecov.
|
sloretz
changed the base branch from
sloretz__fix_bootstrap_find_installed_packages
to
master
…ready been sourced Signed-off-by: Shane Loretz <[email protected]>
sloretz
force-pushed
the
sloretz__no_override_warn_when_same_prefix_sourced
branch
from
4444925 to
c0fe4f2
Compare
jacobperron
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #472 (currently targeting that PR's branch)
Resolves #465
If a user builds a workspace, sources the install space, then builds again the override warning was triggering. This PR avoids warning in that case. It does so by ignoring the install space of the current workspace when looking for packages in underlay's.