Initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cottsay
force-pushed
the
cottsay/implement
branch
from
f2663b6 to
a2b24fc
Compare
cottsay
force-pushed
the
cottsay/implement
branch
from
a2b24fc to
f8328cc
Compare
cottsay
force-pushed
the
cottsay/implement
branch
from
f8328cc to
0c6da79
Compare
Co-authored-by: Steven! Ragnarök <[email protected]>
Co-authored-by: Steven! Ragnarök <[email protected]>
Co-authored-by: Steven! Ragnarök <[email protected]>
Co-authored-by: Steven! Ragnarök <[email protected]>
cottsay
force-pushed
the
cottsay/implement
branch
from
663a0ef to
c0d78f2
Compare
methylDragon
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Just minor doc changes, but aside from that LGTM.
I tried running the entry point on a clean ROS 2 install, and one with a sourced overlay with a clashing package (that caused the overlay install warning to be emitted. (turtlesim: WARNING:colcon.colcon_core.verb:Some selected packages are already built in one or more underlay workspaces:)
Seems to work as expected.
with the relevant augmentation (installed.python, installed.colcon), so we're good to go (:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.