Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also catch FileNotFoundError when detecting multiarch #159

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented May 31, 2024

When the executable we're trying to invoke doesn't exist at all, we'll see a FileNotFoundError and not a subprocess.CalledProcessError.

Fixes #130

When the executable we're trying to invoke doesn't exist at all, we'll
see a FileNotFoundError and not a subprocess.CalledProcessError.
@cottsay cottsay added the bug Something isn't working label May 31, 2024
@cottsay cottsay requested a review from nuclearsandwich May 31, 2024 21:07
@cottsay cottsay self-assigned this May 31, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 6.92%. Comparing base (c5452db) to head (a2d7b1c).
Report is 1 commits behind head on master.

Files Patch % Lines
colcon_ros/task/cmake/__init__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #159   +/-   ##
======================================
  Coverage    6.92%   6.92%           
======================================
  Files          20      20           
  Lines         650     650           
  Branches      139     139           
======================================
  Hits           45      45           
  Misses        605     605           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay added this to the 0.4.2 milestone Jun 3, 2024
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch..

Except it's not called catching in Python. Oh well I tried.

@cottsay cottsay merged commit d4fe6ba into master Jun 13, 2024
17 checks passed
@cottsay cottsay deleted the cottsay/gcc-not-found branch June 13, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

gcc FileNotFoundError
3 participants