Improvements

[indivisualvj]

i use it for my VJ project but i found some issues.

[colejd]

Thanks for the PR! Could you please give me an overview of what you've added in terms of features? The bugfixes are pretty straightforward, but I'm having trouble understanding what your search commit did, for example.

[colejd]

Also, did you make any breaking changes here?

[indivisualvj]

Thanks for your attention!
guify is the best alternative i found to manage applications with LOTS of settings.
In my view i enhanced search behaviour to be more smooth/less greedy or nervous.
Also if you press enter from within the search field, the first option left will be triggered.
This can be a:

• checkbox (being checked/unchecked)
• select (catch focus and expand)
• text (catch focus)
• range (catch focus)
• ...

[indivisualvj]

I made major changes on the MenuBar. The "Controls" Button is now a Search Input. You can search for settings here. And then it will activate on Enter.
Also The MenuBar is now clickable so that you do not need the "Controls" Button anymore.

[colejd]

Gotcha, thank you. I'd respectfully request that you remove your menu bar search code from this PR. My reasoning is that I actually like the search bar you added, funny enough! I see a use case for being able to add arbitrary components to the menu bar, and in your case, it would be a text component.

So there's opportunity for another PR that does two things:

• Allows arbitrary components to be added to the menu bar (would need to figure out how to make that look good).
• Allows any text field to set a timeout, which makes the text field more useful for search (as you've done in this PR).

That way, to get search like you have in this PR, you can just add a text component to the menu bar and hook up the handlers in the same way you'd hook up any other component. Does that sound reasonable for your use case?

[colejd]

I've updated the library to 0.13.1. I made several changes to range.js, which were built on top of your branch. So to fix your PR, you'll just need to rebase keeping my copy of range.js.

[indivisualvj]

Thank you. That all seems to make sense. I'm always happy if someone takes care about doing things well thought out. Will have a look at all of that soon.

[colejd]

Looking good, just a few more small things to address.

[colejd]

Apologies for the conflicts. I made some more changes on my side. Resolving is fairly easy again though -- you can fix by doing the following:

1. Merge my version of master into your branch
2. Resolve conflicts for any of the files in src/components by accepting my changes
3. Run npm run buildall, then resolve merge conflicts in the lib folder by accepting your changes

(These changes update dependencies and build commands, by the way. Run npm install to get the new ones, and check out the readme for details)

[colejd]

I think your merge overwrote my new changes to master, so I'm going to revert them here.

[colejd]

Looking good. Thanks for all your help here!