Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Readme typo in NaNs example #3181

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

RashJrEdmund
Copy link
Contributor

@RashJrEdmund RashJrEdmund commented Jan 24, 2024

  • was reading through docs and saw the typo in this example.

    • see the "invalid_type_error" key-value pair below

Screenshot 2024-01-24 at 11 54 53

  • changed to :
    • "isNaN must be 'not a number'"

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2577e71
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/65b7fc333a0fea0008f35e8d
😎 Deploy Preview https://deploy-preview-3181--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@TahsinAyman TahsinAyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense

@RashJrEdmund
Copy link
Contributor Author

Well, I now understand what it meant.
is Nan must be not a number.
I see why I got confused.
I'll fix that right a way.

@colinhacks
Copy link
Owner

Can't remember why I used NaN as an example for these lol. Guess I was feeling troll-y that day. Your change makes it a bit clearer, thanks.

@colinhacks colinhacks merged commit 11d95a5 into colinhacks:master Feb 3, 2024
4 checks passed
@RashJrEdmund
Copy link
Contributor Author

thank you too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants