add cancel action API #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 29, 2021 09:59
Will be used by the cancel API.
I'm about to add cancel feedback API so we need to distinguish both.
We can skip the optional 'progress' field if it has not been defined, instead of setting it to Null. Needed so we can re-use the existing code to send feedback about cancel actions, which does not support 'progress'.
We can now check if hawkbit returned a cancel action when polling and send feedback about it.
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 96.56% 97.12% +0.55%
==========================================
Files 10 11 +1
Lines 1194 1355 +161
==========================================
+ Hits 1153 1316 +163
+ Misses 41 39 -2
Continue to review full report at Codecov.
|
|
Overall looks fine to me; could you check the one failed test run though? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now check if hawkbit returned a cancel action when polling and send feedback about it.