Implements IDateRangeIndex to exclude DateRecurringIndex by indexes with value in the keys of the catalog plan #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
@jenkins-plone-org please run jobs |
mamico
changed the title
mamico
changed the title
jensens
approved these changes
Jul 22, 2022
thet
approved these changes
Jun 19, 2024
| import unittest | ||
| from datetime import datetime | ||
|
|
||
| import pytz |
There was a problem hiding this comment.
importing here will slow down whenever this module is imported - which is on test discovery, IIRC.
normally, pytz needs some time to be imported.
however, i'll remove this dependency in an upcoming PR, so it's fine to merge here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During analysis on ZCatalog plan (zopefoundation/Products.ZCatalog#138), I saw many entries in the catalog plan with key as
(('start', "{'query': datetime.datetime(2010, 10, 10, 0, 0), 'range': 'min'}"),)(where in my use case start is a
DateRecurringIndex)The fix proposal here avoids this behavior (change here: https://github.com/collective/Products.DateRecurringIndex/compare/mamico/catalogplan?expand=1#diff-2e7e66d717198090a3b8cd8c0152b953b7f12d782a0a46cc381776e6608be5ceR22)
In this PR there is also GitHub action to automate testing.