Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 7529 compatibility #667

Merged
merged 13 commits into from
Jul 3, 2024
Merged

RFC 7529 compatibility #667

merged 13 commits into from
Jul 3, 2024

Conversation

niccokunzmann
Copy link
Member

@niccokunzmann niccokunzmann commented Jun 26, 2024 •
edited
Loading

This tests and adds compatibility to RFC 7529.

Fixes #653
Closes #589

@niccokunzmann niccokunzmann changed the title [WIP] RFC 7529 RFC 7529 compatibility Jun 29, 2024
@niccokunzmann
Copy link
Member Author

This is ready to review and merge.

stevepiercy
stevepiercy requested changes Jun 30, 2024
View reviewed changes
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial formatting fixes, and a couple of questions.

CHANGES.rst Outdated Show resolved Hide resolved
docs/usage.rst Outdated Show resolved Hide resolved
src/icalendar/parser_tools.py Outdated Show resolved Hide resolved
src/icalendar/parser_tools.py Outdated Show resolved Hide resolved
@stevepiercy stevepiercy mentioned this pull request Jun 30, 2024
Closed
@niccokunzmann niccokunzmann mentioned this pull request Jun 30, 2024
Open
6 tasks
niccokunzmann and others added 2 commits June 30, 2024 23:02
@niccokunzmann @stevepiercy
Update src/icalendar/parser_tools.py
df6fd88 
Co-authored-by: Steve Piercy <[email protected]>
@niccokunzmann @stevepiercy
Update CHANGES.rst
88d72e8 
Co-authored-by: Steve Piercy <[email protected]>
stevepiercy
stevepiercy approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the specific RFC details are over my head. But I reckon if there's a problem with its implementation, then someone will let us know. 😁

@niccokunzmann
Copy link
Member Author

@jacadzaca would you like to have a look, too?

@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9778187391

Details

  • 95 of 103 (92.23%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 97.363%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/icalendar/prop.py 67 70 95.71%
src/icalendar/tests/test_rfc_7529.py 18 23 78.26%
Files with Coverage Reduction New Missed Lines %
src/icalendar/prop.py 1 96.69%
Totals Coverage Status
Change from base Build 9778021439: -0.2%
Covered Lines: 3138
Relevant Lines: 3223
💛 - Coveralls

@niccokunzmann niccokunzmann merged commit 02bd019 into collective:main Jul 3, 2024
15 checks passed
@niccokunzmann niccokunzmann deleted the rfc-7529 branch July 3, 2024 13:46
@niccokunzmann
Copy link
Member Author

I just merged it ... review still welcome and opening issues..

I am going towards the Alpha release now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC 7529 - non gregorian RRULE Claiming compatibility to other RFCs/updates of RFC5545
3 participants
@niccokunzmann @coveralls @stevepiercy