Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement content validation #128

Closed
hvelarde opened this issue Aug 31, 2017 · 0 comments · Fixed by #136
Closed

Implement content validation #128

hvelarde opened this issue Aug 31, 2017 · 0 comments · Fixed by #136
Assignees
@hvelarde @claytonc
Labels
enhancement

Comments

@hvelarde
Copy link
Member

hvelarde commented Aug 31, 2017 •
edited
Loading

In order to increase content quality we need to implement validation of the content to be shared. The validator needs to take into account best practices as dictated mainly by Twitter and Facebook:

  • content title should not have more than 70 characters
  • content description should not have more than 200 characters and should contain at least 2 phrases
  • lead image should be in JPG, PNG, WEBP or GIF format
  • lead image dimensions should be at least 600px x 315px and aspect ratio should be 1.33:1 at least
  • lead image size should be less than 5MB

Validation must be executed on content publishing or when published content is edited. Validation is not supposed to enforce these practices, but only warn editors (using a status message) about failure to comply with them.
claytonc pushed a commit that referenced this issue Sep 7, 2017
#128 - Implemented validation of the content to be shared
a532009
claytonc added a commit that referenced this issue Sep 8, 2017
@claytonc
#128 - refactor and check if sc.social.like is intaled
10e1268
claytonc added a commit that referenced this issue Sep 8, 2017
@claytonc
#128 - added info in method
11c1c77
claytonc added a commit that referenced this issue Sep 8, 2017
@claytonc
#128 - pep8
4559b5c
claytonc added a commit that referenced this issue Sep 8, 2017
@claytonc
#128 - fix test image size
9a78ffb
claytonc added a commit that referenced this issue Sep 8, 2017
@claytonc
#128 - started tests for new subscriber
c7b1d06
claytonc pushed a commit that referenced this issue Sep 9, 2017
#128 - altered imports
83afcd2
claytonc pushed a commit that referenced this issue Sep 9, 2017
#128 - add tests subscribers
cd14f74
claytonc pushed a commit that referenced this issue Sep 9, 2017
#128 - remove subscribers for archetypes-based content types
5d78485
claytonc pushed a commit that referenced this issue Sep 9, 2017
#128 - pep8
ae339a4
claytonc pushed a commit that referenced this issue Sep 9, 2017
#128 - corrections
9c00f76
claytonc pushed a commit that referenced this issue Sep 9, 2017
#128 - Dexterity-based content types only
87edb18
claytonc pushed a commit that referenced this issue Sep 9, 2017
#128 - fixed test
e341873
claytonc pushed a commit that referenced this issue Sep 9, 2017
#128 - altered
fb96407
claytonc pushed a commit that referenced this issue Sep 9, 2017
#128 - add extras require
0725a09
claytonc pushed a commit that referenced this issue Sep 9, 2017
#128 - testing request with zope.globalrequest
3fe91fb
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@hvelarde
#128 - Implemented validation of the content to be shared
a80fe1b
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@claytonc @hvelarde
#128 - refactor and check if sc.social.like is intaled
43acf85
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@claytonc @hvelarde
#128 - added info in method
d0fdc7a
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@claytonc @hvelarde
#128 - pep8
1412844
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@claytonc @hvelarde
#128 - fix test image size
bab9b19
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@claytonc @hvelarde
#128 - started tests for new subscriber
1b6fa7a
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@hvelarde
#128 - altered imports
9c65405
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@hvelarde
#128 - add tests subscribers
c444b84
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@hvelarde
#128 - remove subscribers for archetypes-based content types
7b7716d
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@hvelarde
#128 - pep8
7f30891
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@hvelarde
#128 - corrections
5cca13d
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@hvelarde
#128 - Dexterity-based content types only
ea5bece
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@hvelarde
#128 - fixed test
8b5b9c9
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@hvelarde
#128 - altered
3973dfc
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@hvelarde
#128 - add extras require
0410e3f
hvelarde pushed a commit that referenced this issue Sep 12, 2017
@hvelarde
#128 - testing request with zope.globalrequest
65bf7be
@claytonc claytonc mentioned this issue Sep 13, 2017
Merged
hvelarde pushed a commit that referenced this issue Sep 15, 2017
@claytonc @hvelarde
Implement validation of best practices for social networks sharing (#136
bf06b5c 
)

* #128 - Implemented validation of the content to be shared

* #128 - refactor and check if sc.social.like is intaled

* #128 - added info in method

* #128 - pep8

* #128 - fix test image size

* #128 - started tests for new subscriber

* #128 - altered imports

* #128 - add tests subscribers

* #128 -  remove subscribers for archetypes-based content types

* #128 - pep8

* #128 - corrections

* #128 - Dexterity-based content types only

* #128 - fixed test

* #128 - altered

* #128 - add extras require

* #128 - testing request with zope.globalrequest

* Work around code analysis bug

refs. gforcada/flake8-pep3101#16

* Refactor

* Add upgrade step to enable best practices validation

* Update package documentation
claytonc added a commit that referenced this issue Sep 27, 2017
@claytonc
Implement validation of best practices for social networks sharing (#136
fd70ca6 
)

* #128 - Implemented validation of the content to be shared

* #128 - refactor and check if sc.social.like is intaled

* #128 - added info in method

* #128 - pep8

* #128 - fix test image size

* #128 - started tests for new subscriber

* #128 - altered imports

* #128 - add tests subscribers

* #128 -  remove subscribers for archetypes-based content types

* #128 - pep8

* #128 - corrections

* #128 - Dexterity-based content types only

* #128 - fixed test

* #128 - altered

* #128 - add extras require

* #128 - testing request with zope.globalrequest

* Work around code analysis bug

refs. gforcada/flake8-pep3101#16

* Refactor

* Add upgrade step to enable best practices validation

* Update package documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvelarde hvelarde

@claytonc claytonc

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement validation of best practices for social networks sharing collective/sc.social.like
2 participants
@hvelarde @claytonc