Merge pull request #522 from james/fix/dont-require-comment-if-not-au…

…dited-changes

Don't require comment if no audited_changes present

lib/audited/auditor.rb

@@ -326,6 +326,7 @@ def presence_of_audit_comment
 
       def comment_required_state?
         auditing_enabled &&
+        audited_changes.present? &&
           ((audited_options[:on].include?(:create) && new_record?) ||
           (audited_options[:on].include?(:update) && persisted? && changed?))
       end

spec/audited/auditor_spec.rb

@@ -944,6 +944,10 @@ def stub_global_max_audits(max_audits)
         expect(Models::ActiveRecord::CommentRequiredUser.create(name: "Foo")).to be_valid
         Models::ActiveRecord::CommentRequiredUser.enable_auditing
       end
+
+      it "should validate when audit_comment is not supplied, and only excluded attributes changed" do
+        expect(Models::ActiveRecord::CommentRequiredUser.new(password: 'Foo')).to be_valid
+      end
     end
 
     describe "on update" do
@@ -969,6 +973,10 @@ def stub_global_max_audits(max_audits)
         expect(user.update(name: "Test")).to eq(true)
         Models::ActiveRecord::CommentRequiredUser.enable_auditing
       end
+
+      it "should validate when audit_comment is not supplied, and only excluded attributes changed" do
+        expect(user.update(password: 'Test')).to eq(true)
+      end
     end
 
     describe "on destroy" do

spec/support/active_record/models.rb

@@ -42,7 +42,7 @@ class UserRedactedPasswordCustomRedaction < ::ActiveRecord::Base
 
     class CommentRequiredUser < ::ActiveRecord::Base
       self.table_name = :users
-      audited comment_required: true
+      audited except: :password, comment_required: true
     end
 
     class OnCreateCommentRequiredUser < ::ActiveRecord::Base