Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will optimize:
audited/lib/audited/audit.rb
Lines 55 to 56 in c48893a
as they always will be used with
auditable_id
andauditable_type
(like inuser.audits.from_version(100)
), so new index will be used to speed this up;audited/lib/audited/audit.rb
Line 174 in c48893a
Probably, this index should be a
UNIQUE
index, but there are possible race conditions, at least at previously mentioned line.Simple data for testing:
With old index:
With new index:
So, 3 orders of magnitude faster.
Closes #189