Raise error when checking a size of a json ruby value of nil #82
Conversation
|
Travis is failing with your changes. I'm not available to dig into it but please take a look. I'll also leave some feedback on the code itself. Thank you! |
| @@ -35,4 +35,4 @@ Feature: Sizes | |||
| When I get the JSON | |||
| Then the JSON at "one" should have 1 entry | |||
| And the JSON at "two" should have 2 values | |||
| And the JSON at "three" should have 3 numbers | |||
| And the JSON at "three" should have 3 numbers | |||
There was a problem hiding this comment.
Please leave the newlines at the ends of files. Thank you!
|
Hi Steve, |
|
Looks great, Beth. Would you please squash the commits where necessary. Because of the course correction, there are several commits which no longer apply and some commits are just tiny tweaks. Squashing the commits into one or two more feature-focused commits will help keep the Git history readable. Thank you! |
|
Hi Steve, |
|
No, looks great. Thank you. I'll merge shortly when I have time to ship a new release. |
Raise error when checking a size of a json ruby value of nil
|
Version 1.1.4 released. Thank you! |
Hi Steve,
Please let me know what you think about the tests.
Thanks,
Beth