Make ReactElement a proper Monoid and other ergonomic tweaks #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoikin
commented
Jul 29, 2024
Comment on lines
-115
to
-121
| getField :: ∀ @a. CanReceiveFromJavaScript a => String -> ReactComponentInstance -> Effect (Maybe a) | ||
| getField field object = runEffectFn2 getField_ field object <#> readForeign @a | ||
| foreign import getField_ :: EffectFn2 String ReactComponentInstance Foreign | ||
|
|
||
| setField :: ∀ @a. CanPassToJavaScript a => String -> a -> ReactComponentInstance -> Effect Unit | ||
| setField = runEffectFn3 setField_ | ||
| foreign import setField_ :: ∀ a. EffectFn3 String a ReactComponentInstance Unit |
There was a problem hiding this comment.
This moved to a separate module Elmish.React.Internal
fsoikin
commented
Jul 29, 2024
| unmountedField = "__unmounted" | ||
| getUnmounted = getField @Boolean unmountedField >>> map (fromMaybe false) | ||
| setUnmounted = setField @Boolean unmountedField | ||
| unmountedField = Field @"__unmounted" @Boolean |
There was a problem hiding this comment.
The Field value binds together field name and type, making mistakes less likely.
mcordova47
approved these changes
Jul 29, 2024
|
Yep. And |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactElementis now a fullMonoid.readForeignand nested nullables where on error the expected type was reported incorrectly.