Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mid- or late-May pull #789

Merged
merged 15 commits into from
May 17, 2019
Merged

Conversation

DandelionSprout
Copy link
Contributor

@DandelionSprout DandelionSprout commented May 17, 2019

  • Added 2 new lists.
  • Applied a variant of a new uBO SVG file, as suggested in optimized ublock.svg uBlockOrigin/uBlock-issues#573.
  • Categorised the buttons in the Readme, as I at one point thought that several of the buttons were duplicates until I looked at the far-left buttons.

Of particular note is that one of the new lists, I Don't Care about Cookies Nano expansion, technically doesn't exist yet, due to pretty complicated procedures currently being required in order to make stock-settings Nano Adblocker installations make use of ##+js(nanop-easy-set-cookie.js, entries (More details at NanoAdblocker/NanoFilters#331 and at NanoAdblocker/NanoCore#266). It is possible to test the at-the-time-of-writing newest draft of that list at https://raw.githubusercontent.com/NanoAdblocker/NanoFilters/2c7000849b75048a50d1bae11d7bcd7446e86396/ThirdPartyPrivileged/IDCACnano.txt, provided that nanoMakeThirdPartyFiltersPrivileged in the Advanced Settings is set to true.

Additionally, it is maintained by me, supervised by Jspenguin, and is directly based on work by Daniel Kladnik. Thus I listed all three as its maintainers just to be sure.

@perdolka
Copy link

Something wrong with svg:
зображення
Maybe you should leave the "classic" option:
svg viewBox="0 0 .. .." width=".." height=".."
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/icons#SVG

@DandelionSprout
Copy link
Contributor Author

DandelionSprout commented May 17, 2019

Thanks for the heads-up; apparently changing the w3.org definition link back from HTTPS to HTTP resolves it on Google Chrome on my end, for whatever reason.

@collinbarrett collinbarrett added the directory-data changes to basic FilterLists data label May 17, 2019
@collinbarrett collinbarrett merged commit 09358ab into collinbarrett:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants