Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something seems to be going wrong with some new documentation links #1399

Closed
matkoniecz opened this issue Sep 25, 2024 · 2 comments
Closed
Assignees

Comments

@matkoniecz
Copy link
Contributor

@mdsimpson42

Something seems to be going wrong with some links

when I tried to test on staging colouring-cities#355 the CoC link went to

https://cl-staging.uksouth.cloudapp.azure.com/edit/age/https://github.com/colouring-cities/manual/wiki/F2.-PROTOCOLS-&-CODES-OF-CONDUCT#ccrp-contributor-code-of-conduct

it seems that something needs to be set to make it external link, not internal one (or I screwed up merging in upstream changes which is also possible)

@matkoniecz
Copy link
Contributor Author

seems to be part of #1393 - and likely something similar to https://github.com/colouring-cities/colouring-core/pull/1397/files should be applied

mdsimpson42 added a commit that referenced this issue Oct 2, 2024
@mdsimpson42
Copy link
Contributor

I just had a look at this, that link was missing the "external: true" flag that present on all of the other links. I can't see any others that do the same thing, so I will close this issue. We can always open another if we find more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants