Ground work for making mleap scala 2.13 compatible #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dotbg
commented
Aug 17, 2023
•
dotbg
commented
- Using sbt 1.9
- Using most recent versions of the scala libraries where possible
- Replaced scala-arm with more idiomatic scala 2.13+ way (scala-arm was not updated for a long time)
- Updated scalatest.
- Updated ClassloaderUtils to use java 9 compatible code.
- Using java 9 code instead of the commons-io.
dotbg
force-pushed
the
feature/versions-up-new-sbt-scala-2.13-prep
branch
from
920a180 to
ef6f1f1
Compare
dotbg
force-pushed
the
feature/versions-up-new-sbt-scala-2.13-prep
branch
from
ef6f1f1 to
c79afde
Compare
jsleight
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Wow thanks for the massive contribution! I'm still working through it all (about half done), didn't see any issues so far. Just wanted to at least let you know that I'm looking :)
Couple of tests failing still:
- TensorflowModelSpec saved model with
org.tensorflow.exceptions.TFFailedPreconditionException: Attempting to use uninitialized value Variable
- a spring test seems like it didn't compile correctly
Caused by: java.lang.ClassNotFoundException: @.etc.sbt.jvmopts
c79afde to
523a68d
Compare
|
@jsleight thanks a lot! |
jsleight
reviewed
Aug 24, 2023
mleap-spark-testkit/src/main/scala/org/apache/spark/ml/parity/SparkParityBase.scala
Outdated
Show resolved
Hide resolved
dotbg
force-pushed
the
feature/versions-up-new-sbt-scala-2.13-prep
branch
4 times, most recently
from
6b11e07 to
4dfef6b
Compare
1. Using sbt 1.9 2. Using most recent versions of the scala libraries where possible 3. Replaced scala-arm with more idiomatic scala 2.13+ way (scala-arm was not updated for a long time) 4. Updated scalatest. 5. Updated ClassloaderUtils to use java 9 compatible code. 6. Replaced commons-io with java 9+ code.
dotbg
force-pushed
the
feature/versions-up-new-sbt-scala-2.13-prep
branch
from
4dfef6b to
ec0f973
Compare
|
@jsleight thanks for the comments, I've finally made the build green |
jsleight
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.