-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dev #413
Merged
Merged
Feature/dev #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidation genesis updated
Vault/locker fix
update kv store and module for testnet
vishnukumavat
requested review from
bsrinivas8687 and
dheerajkd30
as code owners
August 23, 2022 06:36
dheerajkd30
approved these changes
Aug 23, 2022
dheerajkd30
approved these changes
Aug 23, 2022
interest, err = k.rewards.CalculationOfRewards(ctx, vaultData.AmountOut, collectorLsr, vaultData.BlockTime.Unix()) | ||
if err != nil { | ||
return | ||
interest := sdk.ZeroDec() |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
This definition of interest is never used.
if found { | ||
for _, lockID := range lockers.LockerIds { | ||
lockerData, _ := k.GetLocker(ctx, lockID) | ||
rewards := sdk.ZeroDec() |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
This definition of rewards is never used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.