Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias removal #517

Merged
merged 8 commits into from
Oct 20, 2022
Merged

Alias removal #517

merged 8 commits into from
Oct 20, 2022

Conversation

vishnukumavat
Copy link
Contributor

@vishnukumavat vishnukumavat commented Oct 18, 2022

Changes include -
removal of the alias. go from modules - vault, token mint, rewards, market, locker, and liquidation

defer telemetry.ModuleMeasureSince(types.ModuleName, ctx.BlockTime(), telemetry.MetricKeyBeginBlocker)

_ = utils.ApplyFuncIfNoError(ctx, func(ctx sdk.Context) error {
if k.GetOracleValidationResult(ctx) {
block := k.GetLastBlockheight(ctx)
if bandKeeper.GetOracleValidationResult(ctx) {

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
if k.GetOracleValidationResult(ctx) {
block := k.GetLastBlockheight(ctx)
if bandKeeper.GetOracleValidationResult(ctx) {
block := bandKeeper.GetLastBlockHeight(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
id := k.GetLastFetchPriceID(ctx)
data, _ := k.GetFetchPriceResult(ctx, bandoraclemoduletypes.OracleRequestID(id))
scriptID := k.GetFetchPriceMsg(ctx).OracleScriptID
if ctx.BlockHeight()%types.Int64Twenty == types.Int64Zero && ctx.BlockHeight() != block && bandKeeper.GetCheckFlag(ctx) {

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
data, _ := k.GetFetchPriceResult(ctx, bandoraclemoduletypes.OracleRequestID(id))
scriptID := k.GetFetchPriceMsg(ctx).OracleScriptID
if ctx.BlockHeight()%types.Int64Twenty == types.Int64Zero && ctx.BlockHeight() != block && bandKeeper.GetCheckFlag(ctx) {
assets := assetKeeper.GetAssets(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
scriptID := k.GetFetchPriceMsg(ctx).OracleScriptID
if ctx.BlockHeight()%types.Int64Twenty == types.Int64Zero && ctx.BlockHeight() != block && bandKeeper.GetCheckFlag(ctx) {
assets := assetKeeper.GetAssets(ctx)
id := bandKeeper.GetLastFetchPriceID(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
if ctx.BlockHeight()%types.Int64Twenty == types.Int64Zero && ctx.BlockHeight() != block && bandKeeper.GetCheckFlag(ctx) {
assets := assetKeeper.GetAssets(ctx)
id := bandKeeper.GetLastFetchPriceID(ctx)
data, _ := bandKeeper.GetFetchPriceResult(ctx, bandoraclemoduletypes.OracleRequestID(id))

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
assets := assetKeeper.GetAssets(ctx)
id := bandKeeper.GetLastFetchPriceID(ctx)
data, _ := bandKeeper.GetFetchPriceResult(ctx, bandoraclemoduletypes.OracleRequestID(id))
scriptID := bandKeeper.GetFetchPriceMsg(ctx).OracleScriptID

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
}
}
} else {
assets := k.GetAssets(ctx)
assets := assetKeeper.GetAssets(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@dheerajkd30 dheerajkd30 merged commit 4e6528b into feature/dev Oct 20, 2022
@dheerajkd30 dheerajkd30 deleted the alias_rm branch October 20, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants