OPIK-992 automation fixes #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrescrz
previously approved these changes
Feb 14, 2025
Comment on lines
+334
to
+335
| except Exception as _: | ||
| pass |
There was a problem hiding this comment.
You probably want to log at info level, so we can better debug it if something is unexpected.
There was a problem hiding this comment.
these throwing an exception would not necessarily indicate something unexpected happening, just that it does not need to clean up the created database because it was deleted as part of the test. that said, i will be adding logging fixtures in my next ticket and documenting this too, so staying with this as is for now and adding loggers in the next PR.
andrescrz
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Various automation fixes for small changes to UI in prompt/dataset item tables, also more fixes for ensuring that tests run properly on cloud environments as well.
Pagination buttons issue turned out to be a problem with the newest version of Playwright, where some newly added checks for is_editable() now get called for is_enabled() too, rendering is_enabled() unusable on buttons. Reverted the playwright version and forcing it for now, will raise an issue on the Playwright repo.