Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: change default DB from goleveldb to pebbledb #4122

Merged
merged 11 commits into from
Sep 21, 2024
Merged

feat!: change default DB from goleveldb to pebbledb #4122

merged 11 commits into from
Sep 21, 2024

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Sep 19, 2024

Refs #578

@melekes melekes requested review from a team as code owners September 19, 2024 06:08
@melekes melekes self-assigned this Sep 19, 2024
@melekes melekes added config backport-to-v1.x Tell Mergify to backport the PR to v1.x labels Sep 19, 2024
@melekes

This comment was marked as outdated.

Sign in to view
@andynog

This comment was marked as outdated.

Sign in to view
@andynog

This comment was marked as resolved.

Sign in to view
andynog
andynog approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@melekes
Copy link
Contributor Author

melekes commented Sep 21, 2024

@melekes noticed the tests and build were failing, tested locally and got failures too, realized that some places still used goleveldb as default. So I submitted a PR to fix those, please check if that makes sense 5c31548

Thanks @andynog 👍

@melekes

This comment was marked as resolved.

Sign in to view
@melekes melekes added this pull request to the merge queue Sep 21, 2024
Merged via the queue into main with commit 26f43ce Sep 21, 2024
37 checks passed
@melekes melekes deleted the 578-pebbledb branch September 21, 2024 15:58
mergify bot pushed a commit that referenced this pull request Sep 21, 2024
@melekes @mergify
feat!: change default DB from goleveldb to pebbledb (#4122)
c808773 
Refs #578

---------

Co-authored-by: Andy Nogueira <[email protected]>
(cherry picked from commit 26f43ce)

# Conflicts:
#	common.mk
#	config/config.go
#	config/config.toml.tpl
#	docs/references/config/config.toml.md
#	go.mod
#	node/node_test.go
#	test/e2e/docker/Dockerfile
@mergify mergify bot mentioned this pull request Sep 21, 2024
Merged
@jmalicevic jmalicevic added this to the 2024-Q3 milestone Sep 23, 2024
mergify bot added a commit that referenced this pull request Sep 23, 2024
@mergify @melekes
feat!: change default DB from goleveldb to pebbledb (backport #4122) (#…
77efba8 
…4149)

Refs #578
<hr>This is an automatic backport of pull request #4122 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Anton Kaliaev <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@jmalicevic jmalicevic mentioned this pull request Dec 2, 2024
Closed
@andynog andynog mentioned this pull request Dec 17, 2024
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andynog andynog andynog approved these changes

Assignees

@melekes melekes

Labels
backport-to-v1.x Tell Mergify to backport the PR to v1.x config
Projects
CometBFT
Status: Done
Milestone
2024-Q3
Development

Successfully merging this pull request may close these issues.
3 participants
@melekes @andynog @jmalicevic