FIX post thumbnail type (String -> File)

[wickedev]

• Change the type of schema VelogPost.thumbnail from String to File.
• Upgrade yarn version.
• Upgrade dependencies.
• Update createRemoteFileNode arguments (fix(gatsby-source-filesystem): Update createRemoteFileNode args gatsbyjs/gatsby#35422)

[lgtm-com]

This pull request introduces 19 alerts and fixes 21 when merging 9a27f41 into 6661f86 - view on LGTM.com

new alerts:

• 13 for Expression has no effect
• 4 for Useless conditional
• 1 for Useless assignment to local variable
• 1 for Unneeded defensive code

fixed alerts:

• 13 for Unused variable, import, function or class
• 8 for Useless assignment to local variable

[cometkim]

This is actually not the proper type for the source plugin. because the only thing I can get from the API surface is a string or URL.

You can derive it on your site node, or transformer as you need.

[wickedev]

However, thumbnails of VelogUser, VelogTag, and VelogSeries types are File type. Not only that, as you can see that createRemoteFileNode.id is assigned to post.thumbnail, this seems close to the original intention.

if (post.thumbnail) {
  const thumbnailNode = await createRemoteFileNode({
    url: post.thumbnail,
    store,
    cache,
    reporter,
    createNode,
    createNodeId,
  });
  postSource.thumbnail = thumbnailNode.id;
} else {
  delete postSource['thumbnail'];
}

[wickedev]

Additionally, thumbnail of String is returning null.

[cometkim]

Ah you right. I totally forgot I intented ease of use on this plugin. Maybe I should refactor those types 🤔