Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot let warp handle deserialisation of CreateSwapPayload #83

Open
luckysori opened this issue Jan 4, 2021 · 3 comments
Open

Cannot let warp handle deserialisation of CreateSwapPayload #83

luckysori opened this issue Jan 4, 2021 · 3 comments

Comments

@luckysori
Copy link
Collaborator

Because it contains a SecretKey, which only can be deserialised from borrowed strings.
@luckysori luckysori mentioned this issue Jan 4, 2021
Merged
luckysori added a commit that referenced this issue Jan 4, 2021
@luckysori
Allow handle_create_swap to accept a CreateSwapPayload
8925de6 
By moving the dedicated deserialisation caused by
#83 a layer up.
luckysori added a commit that referenced this issue Jan 4, 2021
@luckysori
Allow handle_create_swap to accept a CreateSwapPayload
8783562 
By moving the dedicated deserialisation caused by
#83 a layer up.
luckysori added a commit that referenced this issue Jan 4, 2021
@luckysori
Allow handle_create_swap to accept a CreateSwapPayload
72e364f 
By moving the dedicated deserialisation caused by
#83 a layer up.
bonomat pushed a commit that referenced this issue Jan 4, 2021
@luckysori @bonomat
Allow handle_create_swap to accept a CreateSwapPayload
76d5a89 
By moving the dedicated deserialisation caused by
#83 a layer up.
bonomat pushed a commit that referenced this issue Jan 4, 2021
@luckysori @bonomat
Allow handle_create_swap to accept a CreateSwapPayload
479a8c6 
By moving the dedicated deserialisation caused by
#83 a layer up.
@thomaseizinger thomaseizinger self-assigned this Jan 5, 2021
@thomaseizinger
Copy link
Contributor

thomaseizinger commented Jan 5, 2021 •
edited
Loading

I am fixing this problem upstream: rust-bitcoin/rust-secp256k1#270

@thomaseizinger thomaseizinger mentioned this issue Feb 8, 2021
Merged
@thomaseizinger thomaseizinger removed their assignment Mar 14, 2021
@thomaseizinger
Copy link
Contributor

rust-bitcoin/rust-secp256k1#270 finally merged!

Meaning we could fix this issue by pointing to latest HEAD using [patch]!

cc @bonomat @luckysori

@luckysori
Copy link
Collaborator Author

@bonomat you can tackle this one now in Bobtimus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomaseizinger @luckysori