Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: JDM Yaris with SecOC #1578

Merged
merged 9 commits into from
Jan 15, 2025
Merged

Conversation

AlexandreSato
Copy link
Contributor

@AlexandreSato AlexandreSato commented Dec 14, 2024

The Japanese toyota yaris has the port (lateral only) almost ready, I believe that just like the rav4 prime should remain excluded from cardocs?

0b54d0594d924cd9/00000041--51e7d1ea2e

user https://github.com/gonzalles125
discord gon0822

@github-actions github-actions bot added car related to opendbc/car/ toyota labels Dec 14, 2024
nelsonjchen added a commit to optskug/docs that referenced this pull request Dec 14, 2024
@jyoung8607
Copy link
Collaborator

Is this the one that needs the radar points parser disabled?

@AlexandreSato
Copy link
Contributor Author

AlexandreSato commented Dec 14, 2024

Is this the one that needs the radar points parser disabled?

Yes is a continental new radar!

We also tried the approach of disabling the radar TX to gain longitudinal control, but even though the radar TX actually stops and we correctly create the 0x183 messages, the car enters a cruise fault state when trying to engage OpenPilot.

@AlexandreSato AlexandreSato marked this pull request as ready for review December 15, 2024 00:41
@AlexandreSato AlexandreSato marked this pull request as draft January 11, 2025 15:16
@AlexandreSato
Copy link
Contributor Author

AlexandreSato commented Jan 11, 2025

@gonzalles125
Copy link

0b54d0594d924cd9/000000d3--aa729fc253/9
The route taken during the test drive after the update.

@AlexandreSato AlexandreSato marked this pull request as ready for review January 12, 2025 21:46
@jyoung8607 jyoung8607 changed the title Toyota: japanese Yaris basic car port Toyota: JDM Yaris with SecOC Jan 15, 2025
@jyoung8607
Copy link
Collaborator

jyoung8607 commented Jan 15, 2025

It looks like the basics are working, but I'm not sure about the lateral control tuning parameters. It's hard to evaluate given the relatively low speed driving in the test route coupled with the model that was in master at the time.

Given the special treatment of SecOC cars, we can merge now and revisit the tune later if needed.

@jyoung8607 jyoung8607 merged commit acdaaa1 into commaai:master Jan 15, 2025
3 checks passed
@AlexandreSato AlexandreSato deleted the port_jpYaris2 branch January 15, 2025 21:49
@sshane
Copy link
Contributor

sshane commented Jan 16, 2025

This seems to be the hybrid variant? Can you fix the docs, or are all Yaris hybrid now?

@AlexandreSato
Copy link
Contributor Author

This seems to be the hybrid variant? Can you fix the docs, or are all Yaris hybrid now?

Yes this is hybrid! And Yaris ICE exists in japan, my bad. Opened: #1641

sshane added a commit that referenced this pull request Jan 22, 2025
sshane added a commit that referenced this pull request Jan 22, 2025
* Revert "Toyota: Yaris SecOC is hybrid (#1641)"

This reverts commit 7af6f38.

* Revert "Toyota: JDM Yaris with SecOC (#1578)"

This reverts commit acdaaa1.
@AlexandreSato AlexandreSato restored the port_jpYaris2 branch January 22, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ toyota
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants