Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust 2017 Lexus IS Hybrid steer_torque_eps value #179

Closed

Conversation

eFiniLan
Copy link
Contributor

@eFiniLan eFiniLan commented Aug 26, 2019

Increase steer_torque_eps value to 1.00 as it can do 1.30

@eFiniLan eFiniLan changed the title Increase steery_torque_eps value to 1.00 as it can do 1.30 Increase steer_torque_eps value to 1.00 as it can do 1.30 Aug 26, 2019
@eFiniLan eFiniLan changed the title Increase steer_torque_eps value to 1.00 as it can do 1.30 Adjust 2017 Lexus IS Hybrid steer_torque_eps value Aug 26, 2019
@rbiasini
Copy link
Contributor

rbiasini commented Sep 3, 2019

@eFiniLan , can you please attach a cabana plot that shows how the factor of 1 is a better over 0.66. I don;t quite understand this comment:

Increase steer_torque_eps value to 1.00 as it can do 1.30

@eFiniLan
Copy link
Contributor Author

eFiniLan commented Sep 4, 2019

@eFiniLan , can you please attach a cabana plot that shows how the factor of 1 is a better over 0.66. I don;t quite understand this comment:

Increase steer_torque_eps value to 1.00 as it can do 1.30

Hi @rbiasini, isn't the factor number should match safetyParam in interface.py? (correct me if I'm wrong 😞 ) I found it turns better (more angle) if I increase the safetyParam to 130 (was at 66). Here is the cabana for running on 1.30 (eps factor) and 130 (safetyParam)

https://my.comma.ai/cabana/?route=1dd19ceed0ee2b48%7C2019-09-03--17-23-39&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F1dd19ceed0ee2b48%2F3e10b9b698e57f584239caa9fe7c79ab_2019-09-03--17-23-39&seekTime=1

@rbiasini
Copy link
Contributor

@eFiniLan yeah, looked at your route and it really seems like you should use a higher factor for STEER_TORQUE_EPS. @quillford , is it the same for your car?

@eFiniLan
Copy link
Contributor Author

move to #192

@eFiniLan eFiniLan closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants