fingerprint 2019 vw jetta sel #23299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What’s the route this fingerprint came from? |
|
Hello
186c80a9e18ac816|2021-12-22--22-42-56
That's the route name
II am new to this if not providing correct information
Please tell me where to get the route
Thanks
Sent from my T-Mobile 5G Device
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Chris McCammon ***@***.***>
Sent: Thursday, December 23, 2021, 10:00 AM
To: commaai/openpilot
Cc: cyanet01; Author
Subject: Re: [commaai/openpilot] fingerprint 2019 vw jetta sel (PR #23299)
What’s the route this fingerprint came from?
—
Reply to this email directly, view it on GitHub<#23299 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AW3ICREM5YTF6LSRV3F2NWTUSNPTPANCNFSM5KUNDAWQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
jyoung8607
reviewed
Dec 24, 2021
| @@ -296,6 +296,7 @@ class CAR: | |||
| b'\xf1\x8704E906024L \xf1\x899970', | |||
| b'\xf1\x8704E906027MS\xf1\x896223', | |||
| b'\xf1\x875G0906259T \xf1\x890003', | |||
| b'\xf1\x8704E906024C \xf1\x899970', | |||
There was a problem hiding this comment.
Move to 3rd on the list
jyoung8607
reviewed
Dec 24, 2021
| @@ -311,6 +312,7 @@ class CAR: | |||
| b'\xf1\x875Q0959655BR\xf1\x890403\xf1\x82\02311170031313300314240011150119333433100', | |||
| b'\xf1\x875Q0959655BR\xf1\x890403\xf1\x82\02319170031313300314240011550159333463100', | |||
| b'\xf1\x875Q0959655CB\xf1\x890421\xf1\x82\x1314171231313500314643021650169333613100', | |||
| b'\xf1\x875Q0959655AG\xf1\x890338\xf1\x82\x1314171231313500314611011630169333463100', | |||
There was a problem hiding this comment.
Move to 2nd on the list
jyoung8607
reviewed
Dec 24, 2021
| @@ -319,10 +321,12 @@ class CAR: | |||
| b'\xf1\x875QM909144C \xf1\x891082\xf1\x82\00521A00642A1', | |||
| b'\xf1\x875QM909144C \xf1\x891082\xf1\x82\00521A10A01A1', | |||
| b'\xf1\x875QN909144B \xf1\x895082\xf1\x82\00571A10A11A1', | |||
| b'\xf1\x875QM909144B \xf1\x891081\xf1\x82\x0521A10A01A1', | |||
jyoung8607
reviewed
Dec 24, 2021
| ], | ||
| (Ecu.fwdRadar, 0x757, None): [ | ||
| b'\xf1\x875Q0907572N \xf1\x890681', | ||
| b'\xf1\x875Q0907572R \xf1\x890771', | ||
| b'\xf1\x875Q0907572P \xf1\x890682', |
There was a problem hiding this comment.
Move to 2nd on the list
jyoung8607
suggested changes
Dec 24, 2021
|
Hello
I don’t believe there is any duplicate lines
Richard
From: Jason Young ***@***.***>
Sent: Thursday, December 23, 2021 8:52 PM
To: commaai/openpilot ***@***.***>
Cc: cyanet01 ***@***.***>; Author ***@***.***>
Subject: Re: [commaai/openpilot] fingerprint 2019 vw jetta sel (PR #23299)
@jyoung8607 commented on this pull request.
________________________________
In selfdrive/car/volkswagen/values.py<#23299 (comment)>:
@@ -319,10 +321,12 @@ class CAR:
b'\xf1\x875QM909144C \xf1\x891082\xf1\x82\00521A00642A1',
b'\xf1\x875QM909144C \xf1\x891082\xf1\x82\00521A10A01A1',
b'\xf1\x875QN909144B \xf1\x895082\xf1\x82\00571A10A11A1',
+ b'\xf1\x875QM909144B \xf1\x891081\xf1\x82\x0521A10A01A1',
Remove; duplicate
—
Reply to this email directly, view it on GitHub<#23299 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AW3ICRHXIBZE75U3PAEPEBDUSP36LANCNFSM5KUNDAWQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Your EPS firmware was already on that list, second position. Automated CI checks later in the process will kick back duplicates, they just weren't running for you yet as a new contributor. I took the liberty of filing #23306 with your commit preserved along with the sorting/dedupe changes so we can go ahead and get you supported. Thank you for the data! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.