Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor default Civic params #720

Merged
merged 7 commits into from
Jul 8, 2019
Merged

Refactor default Civic params #720

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e5328b2
move civic params out
dek3rr Jul 1, 2019
d7e0f25
fix variable name
dek3rr Jul 1, 2019
6f02472
simplify ford scaling
dek3rr Jul 1, 2019
ea8d291
cleanup
dek3rr Jul 2, 2019
aa498a4
remove import dependency
dek3rr Jul 2, 2019
0206f71
requested changes
dek3rr Jul 2, 2019
44b8d0e
keep hyundai
dek3rr Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions selfdrive/car/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
# functions common among cars
from common.numpy_fast import clip
from selfdrive.config import Conversions as CV

# kg of standard extra cargo to count for drive, gas, etc...
STD_CARGO_KG = 136.
LB_TO_KG = 0.453592

# FIXME: hardcoding honda civic 2016 touring params so they can be used to
# scale unknown params for other cars
class CivicParams:
MASS = 2923. * CV.LB_TO_KG + STD_CARGO_KG
MASS = 2923. * LB_TO_KG + STD_CARGO_KG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I mean just put the value in kg :)

WHEELBASE = 2.70
CENTER_TO_FRONT = WHEELBASE * 0.4
CENTER_TO_REAR = WHEELBASE - CENTER_TO_FRONT
Expand Down