Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move commander from SimonBaeumer/commander to commander-cli/commander #140

Merged
merged 9 commits into from
Jul 13, 2020
Merged

Move commander from SimonBaeumer/commander to commander-cli/commander #140

merged 9 commits into from
Jul 13, 2020

Conversation

SimonBaeumer
Copy link
Member

@SimonBaeumer SimonBaeumer commented Jul 7, 2020 •
edited
Loading

Fixes #134

Checklist

  • Added unit / integration tests for windows, macOS and Linux?
  • Added a changelog entry in CHANGELOG.md?
  • Updated the documentation (README.md, docs)?
  • Does your change work on Linux, Windows and macOS?
  • codeclimate integration
  • dependencies
  • travis integration
  • deployment

@SimonBaeumer SimonBaeumer requested a review from dylanhitt July 7, 2020 09:33
@SimonBaeumer SimonBaeumer marked this pull request as draft July 7, 2020 09:33
@SimonBaeumer SimonBaeumer marked this pull request as ready for review July 7, 2020 10:19
@SimonBaeumer SimonBaeumer force-pushed the migrate-repository branch 2 times, most recently from 0c6f4cb to 1cdb5d9 Compare July 7, 2020 12:19
@SimonBaeumer
Copy link
Member Author

SimonBaeumer commented Jul 7, 2020 •
edited
Loading

  • Release deployment needs to be fixed, currently it fails because the oauth token is not actual anymore.
  • Further SimonBaeumer/cmd should be replaced by commander-cli/cmd

@dylanhitt
Copy link
Member

Let me know when this is done. I'll look through the codebase and see if I can find anything.

@SimonBaeumer SimonBaeumer mentioned this pull request Jul 8, 2020
Merged
8 tasks
@SimonBaeumer
Copy link
Member Author

Let me know when this is done. I'll look through the codebase and see if I can find anything.

The migration is finished. I would like to merge #126 before this. The build will break the master branch temporary but imho it shouldn't be a big problem because your current builds work.
After merging of #126 this PR can get merged and can move on with other PRs.

@SimonBaeumer
Copy link
Member Author

@dylanhitt finished, awaiting your review

dylanhitt
dylanhitt approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@dylanhitt dylanhitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you got everything.

The one thing I did notice though is that in the PR template the links to markup files do not work. I believes it's because github doesn't support relative linking in PRs??? I can't really find anything saying it is or isn't 🙃.

Thank you for doing the migration by the way. These things are never fun to do. 👍

@SimonBaeumer SimonBaeumer force-pushed the migrate-repository branch 3 times, most recently from 82fc6b0 to fa48cca Compare July 13, 2020 08:48
@SimonBaeumer
Copy link
Member Author

I think you got everything.

The one thing I did notice though is that in the PR template the links to markup files do not work. I believes it's because github doesn't support relative linking in PRs??? I can't really find anything saying it is or isn't .

Thank you for doing the migration by the way. These things are never fun to do.

Good catch, thanks! Fixed the links and tried it - as you said, github does not support relative links in PRs.

@codeclimate
Copy link

codeclimate bot commented Jul 13, 2020

Code Climate has analyzed commit e554d97 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.4%.

View more on Code Climate.

@SimonBaeumer SimonBaeumer merged commit bde1096 into master Jul 13, 2020
@SimonBaeumer SimonBaeumer deleted the migrate-repository branch July 13, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanhitt dylanhitt dylanhitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving commander to an orginisation
2 participants
@SimonBaeumer @dylanhitt