Add workdir cmdline arg #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimonBaeumer I'll probably have the prototype PR up for the Let me know if this needs any changes. Best |
SimonBaeumer
reviewed
Dec 2, 2020
| @@ -178,6 +178,11 @@ func Test_ConvergeResults(t *testing.T) { | |||
| assert.Equal(t, 1, actual.Failed) | |||
| } | |||
|
|
|||
| func Test_TestCommand_InvalidDir(t *testing.T) { | |||
| err := TestCommand("foo", TestCommandContext{Workdir: "invalid_dir"}) | |||
There was a problem hiding this comment.
this needs a check for windows like
if runtime.GOOS == "windows" {
assert....
} else {
assert...
}
|
LGTM, only one small change necessary in the unit tests for windows |
dylanhitt
force-pushed
the
add-workdir-cmdline-arg
branch
from
8341543 to
bda6b73
Compare
|
Code Climate has analyzed commit bda6b73 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 92.4% (0.0% change). View more on Code Climate. |
SimonBaeumer
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156
Checklist
Linux,WindowsandmacOS?