Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change province > region (France country) #161

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

comxd
Copy link
Contributor

@comxd comxd commented Jul 21, 2021

@bojanz
Copy link
Contributor

bojanz commented Jul 21, 2021

You are correct.

Unfortunately, the administrative_area_type for France is also wrong, raised that upstream at: google/libaddressinput#220

@bojanz bojanz merged commit 10421cd into commerceguys:master Jul 21, 2021
@bojanz
Copy link
Contributor

bojanz commented Jul 21, 2021

Merged, thanks! I'll tackle the administrative_area_type in a followup. If upstream doesn't fix it within the next few weeks I'll add a library override.

@comxd comxd deleted the patch-1 branch July 21, 2021 11:43
@comxd
Copy link
Contributor Author

comxd commented Jul 21, 2021

Good, thanks @bojanz!

bojanz added a commit that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants