-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stack 1.7.1 still has problems finding build tools ("The program 'happy' is required") #4125
Comments
Can you also try with the stack from I think this has been solved on master, accidentally, but I'm not completely sure. |
I'll report back.. it's taking a while.
|
I can still reproduce with stack-git: https://ci.appveyor.com/project/simonmichael/hledger/build/master-497 |
As part of #3922, I was discussing the behavior of the build tool detection with @bitemyapp. It might make sense to copy the behavior that cabal-install 2.0 (or 2.2?) added for build tool detection, which unless I'm mistaken comes down to something like:
That would likely bypass many cases where it becomes difficult/impossible to determine which package was intended, as well as allow us to much more lazily parse cabal files (since we needn't know all executables provided by all packages in a snapshot). |
BTW, adding an explicit |
Sorry, last comment for a bit: do you have any kind of local repro for this? I haven't been able to trigger it on my OS X system at least. |
I don't, sorry. I don't see it on mac either, or gnu/linux. https://ci.appveyor.com/project/simonmichael/hledger/build/master-458?fullLog=true seems to show that explicitly pre-installing happy didn't help (again unless I'm missing some path issue like a .\happy.exe, but I don't think so). |
@simonmichael could you try using the |
@snoyberg sorry but I've had trouble installing this branch of stack. I've been trying |
What I'd do would be to clone the repo and checkout the branch then |
I think that's because you're missing the |
Doh, you're right. |
It looks to me like my AppVeyor build didn't have this bug. The build failed, but that seems to be for an unrelated reason (maybe a timeout?). Can you confirm @simonmichael? |
Your latest looks good! And mine too. |
So I gather that #4132 solves this, 👍 |
…d-tools Use a hard-coded tool dependency map (fixes #4125)
Note that the previous workaround for #4125 should no longer be necessary because: 1. Stack 1.9 will not suffer from that bug 2. To my knowledge, custom snapshots never suffered from that bug Guess we'll find out when Travis takes a crack at this though!
This bumps us to newer versions of some libraries, in particular conduit, which were previously blocked by #4125. Using a custom snapshot should allow this by bypassing that bug.
General summary/comments (optional)
hledger appveyor builds are failing due to not being able to find "happy" when building pretty-show, haskell-src-exts, language-javascript. simonmichael/hledger#832
I saw this a month ago and tried several things to fix it, and probably thought I had solved it by upgrading to stack 1.7.1, but now it seems not.
Possibly related:
#595
#3178
#3249
Steps to reproduce
I don't have a short repro, instead I'll point to appveyor logs.
Expected
Successful builds of pretty-show, haskell-src-exts, language-javascript.
Actual
These packages failed to build due to "missing happy", even with stack 1.7.1. Eg see
https://ci.appveyor.com/project/simonmichael/hledger/build/master-460.
Some more details:
hledger build history: https://ci.appveyor.com/project/simonmichael/hledger/history.
Only the full, >30m builds are building pretty-show etc.
The last full build that succeeded was https://ci.appveyor.com/project/simonmichael/hledger/build/master-451 on 26 May. The stack version is not reported, but it fetched http://www.stackage.org/stack/windows-x86_64, and stack 1.7.1 was released on 27 Apr, so I would have thought it was using stack 1.7.1. Unless there was some path issue.
The next full build, 456 on 30 May, failed with
No packages found in snapshot which provide a "happy" executable, which is a build-tool dependency of "pretty-show"
warnings andThe program 'happy' version >=1.19 is required but it could not be found
errors. So did build 460 and later, and these report the stack version as definitely 1.7.1. https://ci.appveyor.com/project/simonmichael/hledger/build/master-460.Builds 459, 462 and 465 were non-full builds that succeeded by luck, appveyor apparently picks randomly from several build instances each with their own cache state.
Stack version
1.7.1
Method of installation
Official binary, downloaded from stackage.org or fpcomplete's package repository
The text was updated successfully, but these errors were encountered: