Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stack path: Rename --ghc-paths to --programs-path, add --compiler-path #1546 #2016

Merged
merged 3 commits into from
Apr 11, 2016
Merged

stack path: Rename --ghc-paths to --programs-path, add --compiler-path #1546 #2016

merged 3 commits into from
Apr 11, 2016

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Apr 9, 2016

No description provided.

@sjakobi sjakobi changed the title stack path: Remove --ghc-paths, add --compiler-path stack path: Remove --ghc-paths, add --compiler-path #1546 Apr 9, 2016
@sjakobi
Copy link
Member Author

sjakobi commented Apr 9, 2016

There's another reference to --ghc-paths in the guide where I'm not quite sure how to update it because I don't have a Windows system:

On Windows, you will also need to delete stack path --ghc-paths

@mgsloan
Copy link
Contributor

mgsloan commented Apr 11, 2016

I think that comment should be updated with --programs-path (and an implementation of it). I suppose this is the usecase for the existence of such a flag. The issue is that on windows, the programs path goes into some appdata dir in the user folder, or something like that.

@sjakobi
Copy link
Member Author

sjakobi commented Apr 11, 2016

I think that comment should be updated with --programs-path (and an implementation of it).

Done!

@sjakobi sjakobi changed the title stack path: Remove --ghc-paths, add --compiler-path #1546 stack path: Rename --ghc-paths to --programs-path, add --compiler-path #1546 Apr 11, 2016
@mgsloan
Copy link
Contributor

mgsloan commented Apr 11, 2016

Thanks!!

@mgsloan mgsloan merged commit 2e7e684 into commercialhaskell:master Apr 11, 2016
@sjakobi sjakobi deleted the 1546-ghc-path branch April 11, 2016 22:32
@sjakobi sjakobi mentioned this pull request Apr 11, 2016
Closed
@mgsloan
Copy link
Contributor

mgsloan commented Apr 13, 2016

FYI, I've made a few updates that bikeshed this a bit, while it's easy to change: 2f7755d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjakobi @mgsloan @borsboom