DWARF debugging support #2801
Merged
DWARF debugging support #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typedrat
changed the title
|
|
typedrat
force-pushed
the
stripping-option
branch
2 times, most recently
from
cd4498f to
d9f2f03
Compare
typedrat
force-pushed
the
stripping-option
branch
from
d9f2f03 to
65a4872
Compare
|
It does build correctly on Linux and OS X, Travis just seems to have had a bad hair day when my commit was going through. |
|
While I'm a bit wary of the approach used to detect debugging symbols, this seems like a good change. Let's give it a try - thanks for implementing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It passes all tests that are in the repo, and in my own tests on OS X it does indeed produce output that contains debugging symbols. I don't have access to any other operating systems to test on at the moment, though.
This would close #877.