Remove psupstream #3351
Merged
Remove psupstream #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is bringing us closer to the right way of handling things, now that extensible snapshots are a reality. We have two kinds of packages: those with files on the filesystem, and those with files from an index. We need to break the idea that only local packages depend on the filesystem, it's no longer true.
snoyberg
force-pushed
the
remove-psupstream
branch
from
6dd1711 to
47f83e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concept of PSUpstream no longer makes sense: it's possible to have snapshot packages which don't come from the package index now that extensible snapshots exist. This is a tactical change to fix some broken assumptions.
Overall, the code and types could use a more significant cleanup to make things easier to follow and less error prone. I want to get this change in without getting held up further by a grander vision. I'll add comments on a separate issue explaining what I think can be improved in the future.