Don't pass --with-hpack to Setup.hs configure #3696

[mgsloan]

Pinging @scott-fleischman - any thoughts on why this worked with #3443 ? Maybe Cabal-1.24 was less strict about --with-* options?

Please include the following checklist in your PR:

• Any changes that could be relevant to users have been recorded in the ChangeLog.md
• The documentation has been updated, if necessary.

Tested by

stack new issue3696
cd issue3696
stack build hpack
stack build --with-hpack=hpack

(reproduced the issue)

After this fix, the issue no longer occurs.

[scott-fleischman]

I don't know why it worked before—the less strict idea is a reasonable guess. I imitated the with-ghc code I think initially and neglected to review this code to see if it made sense. Thanks for fixing it!

[mgsloan]

Cool, no worries @scott-fleischman , just curious if there was a particular usecase for passing it into configure.