Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rio package as a dep of stack #3776

Closed
wants to merge 1 commit into from
Closed

Add rio package as a dep of stack #3776

wants to merge 1 commit into from

Conversation

mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Jan 15, 2018

Otherwise, "stack ghci" fails to run due to

The following modules are present in multiple packages:

  • Path.Extra (in stack, rio)
  • RIO (in stack, rio)
  • RIO.Logger (in stack, rio)
  • RIO.Prelude (in stack, rio)
  • RIO.Process (in stack, rio)

@mgsloan
Add rio package as a dep of stack
59f0789 
Otherwise, "stack ghci" fails to run due to

> The following modules are present in multiple packages:
>  * Path.Extra (in stack, rio)
>  * RIO (in stack, rio)
>  * RIO.Logger (in stack, rio)
>  * RIO.Prelude (in stack, rio)
>  * RIO.Process (in stack, rio)
@mgsloan mgsloan requested a review from snoyberg January 15, 2018 02:08
@snoyberg
Copy link
Contributor

This is different from our original plan, but I'm OK with this approach. Once the external rio gets a bit more stable, we should switch over to that. @borsboom are you OK with this switch?

@mgsloan
Copy link
Contributor Author

mgsloan commented Jan 15, 2018 •
edited
Loading

Actually, I've considered it further, and this seems like an issue in stack ghci. It shouldn't balk about duplicate module names if they are literally the same files.

mgsloan added a commit that referenced this pull request Jan 15, 2018
@mgsloan
With ghci, allow multiple packages to use the same module #3776
864831f
@mgsloan mgsloan mentioned this pull request Jan 15, 2018
Merged
2 tasks
@mgsloan
Copy link
Contributor Author

mgsloan commented Jan 15, 2018

The fix to stack ghci in #3779 makes this unnecessary, so closing.

@mgsloan mgsloan closed this Jan 15, 2018
mgsloan added a commit that referenced this pull request Jan 16, 2018
@mgsloan
Merge pull request #3779 from commercialhaskell/ghci-distinct-duplica…
eea633a 
…te-modules-3776

With ghci, allow multiple packages to use the same module #3776
@mihaimaruseac mihaimaruseac deleted the add-rio-as-dep branch July 30, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg Awaiting requested review from snoyberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgsloan @snoyberg