-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'list' command to query package-version in snapshot #5431
Conversation
I would appreciate any feedback, comments, code review of this. I find this command quite useful - certainly faster than querying stackage.org directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I guess we need to have an opinion from one of Stack's maintainers as well to merge this in. Also a changelog entry looks to be needed in that case and probably mentioning it in the docs.
Also style job error needs to be fixed |
Sure, thanks, @qrilka, I will try to get to it soon. (Maybe I will try to check on core library handling too at the same time, though I think it's already quite useful.) |
I add a Changelog entry and short documentation. Also fixed the hlint warning, and updated package.yaml. |
36c9b4b
to
519754f
Compare
I slightly tweaked the documentation and changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with merging this but would like to understand the point of FIXME in the code.
Thank you.
- currently not working for core ghc libs with resolver - without a resolver the latest Hackage version is displayed
Okay, I dropped the comment, thanks |
Great, thanks |
Thanks @qrilka for reviewing and helping to get this ready |
@juhp, may I clarify how this command is intended to work when no packages are specified at the command line? If I command:
it yields a long list of what looks like the packages in If I command:
it yields nothing. I was rather hoping it would yield the snapshot specified by Stack's project-level configuration file ( |
I believe that is the current behaviour yes. I mean I would like the boot libraries to be listed too, but I didn't manage to wrangle that - if it's straightforward to do that would be great, thanks! (I did briefly mention this deficiency during the review.) And right, the project case seems another edge case - it would be good to fix that too - I wasn't clever enough at the time. (I was aware of this but maybe didn't call it out explicitly here - dunno if my dropped fixme comment was alluding to this.) |
@juhp, many thanks. For now. I've updated the online documentation to describe more fully the existing command. |
currently not working for core ghc libs with resolver
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!