-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add msgpack #4471
add msgpack #4471
Conversation
working on that third checklist item. template-haskell version bound for msgpack-idl too tight |
Thanks for the PR. I'll take a closer look later today and see if I can help. |
Finally,
|
I've taken the liberty of merging in what we can for now. Kindly open a new PR once upgraded versions of any of the above mentioned packages become available on hackage. Also feel free to open an issue if you'd like to track progress on those other packages getting into stackage. I'll post comments there, or on this merged PR, if I have any updates to share. |
Nice, thank you Dan! Sorry for not reacting faster. How did you specify the versions? They are not in build-contraints, so I don't know yet what kind of PR to open if upstream bumps their dependencies. |
@2mol the "latest" version is selected by default; so in most cases the version need not be specified explicitly, and the PR you open will look just like this one. There is a syntax for constraining a package to older versions, but that doesn't apply to this case. |
Thanks for explaining! |
Checklist:
Meaningful commit message, eg
add my-cool-package
(please not mentionbuild-constraints.yml
)At least 30 minutes have passed since uploading to Hackage
On your own machine, in a new directory, you have successfully run the following set of commands (replace
$package
with the name of the package that is submitted, and$version
with the version of the package you want to get into Stackage):