Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add msgpack #4471

Merged
merged 4 commits into from
Apr 10, 2019
Merged

add msgpack #4471

merged 4 commits into from
Apr 10, 2019

Conversation

2mol
Copy link
Contributor

@2mol 2mol commented Apr 9, 2019

Checklist:

  • Meaningful commit message, eg add my-cool-package (please not mention build-constraints.yml)

  • At least 30 minutes have passed since uploading to Hackage

  • On your own machine, in a new directory, you have successfully run the following set of commands (replace $package with the name of the package that is submitted, and $version with the version of the package you want to get into Stackage):

    stack unpack $package-$version  # $version is optional
    stack init --resolver nightly
    stack build --resolver nightly --haddock --test --bench --no-run-benchmarks
    

@2mol
Copy link
Contributor Author

2mol commented Apr 9, 2019

working on that third checklist item.

template-haskell version bound for msgpack-idl too tight

@DanBurton
Copy link
Contributor

Thanks for the PR. I'll take a closer look later today and see if I can help.

@DanBurton
Copy link
Contributor

msgpack (1.0.1.0) and msgpack-aeson (0.1.0.0) can be included as is, tests and all.

int-cast (0.2.0.0) can be included if we skip tests. It's tests can be included if it is upgraded to work with QuickCheck-2.12.6.1 (currently requires == 2.11.*)

binary-conduit (1.3.1) needs to be upgraded to support newer versions of binary-conduit, conduit, and conduit-extra before it can be included:

binary-conduit-1.3.1 is out of bounds for:
- msgpack-rpc-1.0.0 (>=1.2.3 && < 1.3). Juri Chomé <[email protected]> @2mol. @msgpack. Used by: library

conduit-1.3.1.1 (Grandfathered dependencies) is out of bounds for:
- msgpack-rpc-1.0.0 (>=1.2.3.1 && < 1.3). Juri Chomé <[email protected]> @2mol. @msgpack. Used by: library

conduit-extra-1.3.1.1 is out of bounds for:
- msgpack-rpc-1.0.0 (>=1.1.3.4 && < 1.3). Juri Chomé <[email protected]> @2mol. @msgpack. Used by: library

Finally, msgpack-idl (0.2.1), as well as its dependency peggy (0.3.2), need to support a number of dependency upgrades before they can be included:

ListLike-4.6 (Grandfathered dependencies) is out of bounds for:
- [ ] peggy-0.3.2 (==3.1.*). No maintainer. @tanakh. Used by: library

blaze-builder-0.4.1.0 (Grandfathered dependencies) is out of bounds for:
- [ ] msgpack-idl-0.2.1 (==0.3.*). Juri Chomé <[email protected]> @2mol. @msgpack. Used by: library

filepath-1.4.2.1 is out of bounds for:
- [ ] msgpack-idl-0.2.1 (>=1.1 && < 1.4). Juri Chomé <[email protected]> @2mol. @msgpack. Used by: library

hashtables-1.2.3.1 (Gregory Collins <[email protected]> @gregorycollins) is out of bounds for:
- [ ] peggy-0.3.2 (==1.0.*). No maintainer. @tanakh. Used by: library

monad-control-1.0.2.3 (Grandfathered dependencies) is out of bounds for:
- [ ] peggy-0.3.2 (==0.3.*). No maintainer. @tanakh. Used by: library

msgpack-1.0.1.0 (Juri Chomé <[email protected]> @2mol) is out of bounds for:
- [ ] msgpack-idl-0.2.1 (==0.7.*). Juri Chomé <[email protected]> @2mol. @msgpack. Used by: library

shakespeare-text-1.1.0 is out of bounds for:
- [ ] msgpack-idl-0.2.1 (==1.0.*). Juri Chomé <[email protected]> @2mol. @msgpack. Used by: library

template-haskell-2.14.0.0 is out of bounds for:
- [ ] msgpack-idl-0.2.1 (>=2.5 && < 2.9). Juri Chomé <[email protected]> @2mol. @msgpack. Used by: library
- [ ] peggy-0.3.2 (>=2.5 && < 2.9). No maintainer. @tanakh. Used by: library

@DanBurton DanBurton merged commit 25aff62 into commercialhaskell:master Apr 10, 2019
@DanBurton
Copy link
Contributor

I've taken the liberty of merging in what we can for now. Kindly open a new PR once upgraded versions of any of the above mentioned packages become available on hackage.

Also feel free to open an issue if you'd like to track progress on those other packages getting into stackage. I'll post comments there, or on this merged PR, if I have any updates to share.

@2mol
Copy link
Contributor Author

2mol commented Apr 26, 2019

Nice, thank you Dan! Sorry for not reacting faster. How did you specify the versions? They are not in build-contraints, so I don't know yet what kind of PR to open if upstream bumps their dependencies.

@DanBurton
Copy link
Contributor

@2mol the "latest" version is selected by default; so in most cases the version need not be specified explicitly, and the PR you open will look just like this one. There is a syntax for constraining a package to older versions, but that doesn't apply to this case.

@2mol
Copy link
Contributor Author

2mol commented Apr 27, 2019

Thanks for explaining!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants