Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uv provider #1349

Closed
Lee-W opened this issue Jan 31, 2025 · 5 comments · Fixed by #1351
Closed

Add uv provider #1349

Lee-W opened this issue Jan 31, 2025 · 5 comments · Fixed by #1351
Labels
good first issue issue-status: wait-for-implementation maintainers agree on the bug / feature type: feature A new enhacement proposal

Comments

@Lee-W
Copy link
Member

Lee-W commented Jan 31, 2025

Description

support updating both pyprojec.toml and uv.lock

Possible Solution

No response

Additional context

No response

Additional context

No response

@woile
Copy link
Member

woile commented Jan 31, 2025

Should we extend pep440 to detect the presence of uv.lock?

Lee-W added a commit that referenced this issue Jan 31, 2025
@Lee-W
Copy link
Member Author

Lee-W commented Jan 31, 2025

Should we extend pep440 to detect the presence of uv.lock?

yep, sounds like a good idea!

@lsorber
Copy link

lsorber commented Feb 17, 2025

We're using Commitizen for Substrate and we noticed that you cannot just run cz bump with a uv project because bumping the version number causes uv.lock to be out of sync with pyproject.toml.

Until Commitizen supports uv.lock, would you recommend adding uv lock --offline to the pre_bump_hooks as a workaround?

Lee-W added a commit that referenced this issue Feb 18, 2025
Lee-W added a commit that referenced this issue Feb 18, 2025
Lee-W added a commit that referenced this issue Feb 18, 2025
@Lee-W
Copy link
Member Author

Lee-W commented Feb 18, 2025

We're using Commitizen for Substrate and we noticed that you cannot just run cz bump with a uv project because bumping the version number causes uv.lock to be out of sync with pyproject.toml.

Until Commitizen supports uv.lock, would you recommend adding uv lock --offline to the pre_bump_hooks as a workaround?

yep, that could be a workaround. I just wrap up my PR #1351. I think we can have this feature soon!

Lee-W added a commit that referenced this issue Feb 28, 2025
@Lee-W Lee-W closed this as completed in 7805412 Feb 28, 2025
@khrapovs
Copy link

Thank you so much for this, I've been waiting for it! But unfortunately you have forgotten to document it for the users like me ;) I think this feature deserves to be mentioned in https://commitizen-tools.github.io/commitizen/config/#version-providers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue issue-status: wait-for-implementation maintainers agree on the bug / feature type: feature A new enhacement proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants