Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr refactor: better interface #40

Merged
merged 1 commit into from
Nov 9, 2020
Merged

expr refactor: better interface #40

merged 1 commit into from
Nov 9, 2020

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Nov 9, 2020

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Nov 9, 2020

This pull request introduces 1 alert when merging e1ada37 into 4314c91 - view on LGTM.com

new alerts:

  • 1 for Nested loops with same variable

@mr-c mr-c force-pushed the more_etools_tests branch from e1ada37 to 5783c17 Compare November 9, 2020 15:01
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #40 (2b8a4d1) into main (4314c91) will increase coverage by 0.04%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   28.46%   28.50%   +0.04%     
==========================================
  Files          10       10              
  Lines        5945     5968      +23     
==========================================
+ Hits         1692     1701       +9     
- Misses       4253     4267      +14     
Impacted Files Coverage Δ
tests/test_docker_extract.py 57.69% <35.29%> (ø)
cwl_utils/cwl_expression_refactor.py 14.06% <43.07%> (ø)
tests/test_cite_extract.py 100.00% <100.00%> (ø)
tests/test_etools_to_clt.py 100.00% <100.00%> (ø)
tests/test_graph_split.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4314c91...2b8a4d1. Read the comment docs.

@mr-c mr-c force-pushed the more_etools_tests branch from 5783c17 to ab73cbb Compare November 9, 2020 15:25
@mr-c mr-c force-pushed the more_etools_tests branch from ab73cbb to 2b8a4d1 Compare November 9, 2020 15:39
@mr-c mr-c merged commit 5306f68 into main Nov 9, 2020
@mr-c mr-c deleted the more_etools_tests branch November 9, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant