Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foo](<bar>"baz") interpretation #229

Closed
shyouhei opened this issue Aug 10, 2017 · 2 comments
Closed

[foo](<bar>"baz") interpretation #229

shyouhei opened this issue Aug 10, 2017 · 2 comments

Comments

@shyouhei
Copy link

Current implementation does not understand the subject input:

% echo '[foo](<bar>"baz")' | cmark
<p>[foo](<bar>&quot;baz&quot;)</p>

However, I think <bar>"baz" is a valid link destination. The spec http://spec.commonmark.org/0.28/#link-destination says:

A link destination consists of either

  • a sequence of zero or more characters between an opening < and a closing > that contains no spaces, line breaks, or unescaped < or > characters, or
  • a nonempty sequence of characters that does not include ASCII space or control characters, and includes parentheses only if (a) they are backslash-escaped or (b) they are part of a balanced pair of unescaped parentheses. (Implementations may impose limits on parentheses nesting to avoid performance issues, but at least three levels of nesting should be supported.)

Isn't it clear that <bar>"baz" is "a nonempty sequence of characters that does not include ASCII space or control characters" ?

@mity
Copy link
Contributor

mity commented Aug 10, 2017

I believe this is duplicate of #193 (comment).

@shyouhei
Copy link
Author

Yes, it seems to be. I wasn't aware of that issue. Thank you for pointing this out.

Feel free to close this one.

@jgm jgm closed this as completed Mar 19, 2019
QuietMisdreavus pushed a commit to swiftlang/swift-cmark that referenced this issue Dec 29, 2021
…nkrefs-autolinker

Fix footnotes: nested, confused for link refs & mangled by the autolinker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants