-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json does not list devDependencies #142
Comments
I don't know much about npm packaging, so feel free to educate me. But
I don't want to require the benchmark dependencies (e.g. showdown) as
part of "dependencies," since that would mean that anyone installing
commonmark.js will have to install all of those dependencies too.
Benchmarks are useful for developers, but end-users shouldn't have
to install the benchmark dependencies. Same goes for programs
used for linting.
|
That's what |
jgm
pushed a commit
that referenced
this issue
Jun 8, 2018
* Use local development dependencies Packages used during development are now listed in devDependencies of package.json. Makefiles are updated to use those local versions. References to manually installing packages are removed from README.md and bench/bench.js. The package-lock.json file used in newer NPM versions is also added. Fixes: #142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The packages used during development should be included in
package.json
. Many are listed in the readme or installed via make. The project should conform to the standard development route of using a singlenpm install
to setup the environment.The text was updated successfully, but these errors were encountered: