-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test_type to TestDesc to compile on nightly rust #19
Conversation
Ok, so:
It seems like a lot of work to paper over all the libtest API we use to keep the stable guarantee... what other changes is libtest undergoing? Are there going to be changes that will break the ability to provide the facade? |
Yeah... I've been waiting for rust-lang/rust#50297 to happen, which would, hopefully, solve these woes. |
I think, clippy runs on stable so maybe it doesn't need that feature set? |
No, the clippy task is running on nightly. |
Thanks for doing the work! |
Not sure if this should be more complicated, e.g.:
if_rust_version
to do what the unimplementedcfg
s would do andenable test_type for those 6-day-old nightlies
Also obviously this is going to fail most tests