Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/uar 1635 save resume deselect nocs #1631

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lduranteau
Copy link
Contributor

JIRA link

https://companieshouse.atlassian.net/browse/UAR-1635

Change description

Save and Resume: Deselect invalid NOCs when returning to web journey after new NOCs are implemented.
Add error message if nature of control is an empty list

Work checklist

  • Tests added where applicable
  • UI changes meet accessibility criteria

Merge instructions

We are committed to keeping commit history clean, consistent and linear. To achieve this, this commit should be structured as follows:

<type>[optional scope]: <description>

and contain the following structural elements:

  • fix: a commit that patches a bug in your codebase (this correlates with PATCH in semantic versioning),
  • feat: a commit that introduces a new feature to the codebase (this correlates with MINOR in semantic versioning),
  • BREAKING CHANGE: a commit that has a footer BREAKING CHANGE: introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type,
  • types other than fix: and feat: are allowed, for example build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others,
  • footers other than BREAKING CHANGE: <description> may be provided.

Copy link
Contributor

@mwestacott mwestacott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Suggest adding a comment to the JIRA story and tagging testers letting them know that the Registration behaviour has also changed (fixes that bug you found). They'll need to regression test that journey now too.

@chsonarqubeprchecks
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants