Improved error handling and recovery

src/caching.rs

@@ -169,7 +169,9 @@ fn tag_mp3<P: AsRef<Path>>(track: &PlaylistTrack, path: P) -> Result<()> {
 
 fn save_url_to_file<P: AsRef<Path>>(url: &str, path: P) -> Result<()> {
     let mut resp = reqwest::blocking::get(url)
-        .with_context(|| format!("Failed while retrieving content from url {}", url))?;
+        .with_context(|| format!("Failed while retrieving content from url {}", url))?
+        .error_for_status()
+        .with_context(|| format!("Error response while retrieving content from url {}", url))?;
 
     let file = std::fs::File::create(path.as_ref()).with_context(|| {
         format!(

src/model.rs

@@ -395,6 +395,13 @@ impl PlaybackMediator for Playing {
                 Some(serde_json::value::Value::String(cached)) => PathBuf::from(cached.clone()),
                 _ => match caching::add_to_cache(track) {
                     Err(e) => {
+                        if let Some(e) = e.downcast_ref::<reqwest::Error>() {
+                            if e.is_status() {
+                                error!("Failed caching track due to http error: {:?}", e);
+                                self.evict_playing();
+                                return;
+                            }
+                        }
                         error!("Failed caching track: {:?}", e);
                         return;
                     }
@@ -727,6 +734,7 @@ impl StateMediator for Model {
                 trace!("start dirtied");
             }
         } else if self.config.borrow().login_credentials().get().is_some() {
+            self.disconnect();
             self.connect();
             if !old_dirty && (old_dirty != self.dirty) {
                 trace!("connect dirtied");