Miscellaneous performance improvements #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
force-pushed
the
wip/perf/misc
branch
from
fd5d60c to
947cbe0
Compare
- Fix INLINE pragmas. - Change the return type of integerValue, in order to deal with potential integer overflow.
wismill
force-pushed
the
wip/perf/misc
branch
3 times, most recently
from
5b99cc9 to
2112d4f
Compare
* Reduce script bitmap * Add scriptShortName * Add inScript * Refactor scriptDescription * Refactor scriptExtensions * Add ICU comparison * Do not depends on unicode-data * Cabal: improve bench options
|
I got nice performance improvements in general but also some regressions in Anyway, this PR is getting too big, so I am going to split it in various ones, starting with #109. |
|
FYI, I am working on rebasing & splitting this PR into smaller PR. I will not make the mistake again with a huge PR. Leaving this open while not completely ported. |
Merged
|
So long, big unmergeable PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to work here on performance.
I may introduce breaking changes when I encounter a discutable design decision.