Measure container onLayout #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@computerjazz any reason not to merge this? It's the proper way to measure - using onLayout and not a timeout, which is going to cause race condition issues. |
|
Any ETA for this merge to be released on npm? |
|
published 1.1.9 btw, I've just rewritten this package using reanimated + react-native-gesture-handler. It should be way more performant, especially on android -- any interest in helping test it out? https://github.com/computerjazz/react-native-draggable-flatlist/pull/81/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #70 and maybe also #58. Container is sometimes measured before component is rendered (due to a too short setTimeout) and getting the offset wrong. I guess it should not depend on a setTimeout but rather onLayout when the component is fully rendered.